Skip to content

Conversation

@jgarzik
Copy link
Contributor

@jgarzik jgarzik commented Apr 2, 2025

No description provided.

@jgarzik jgarzik requested a review from Copilot April 2, 2025 04:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a warning cleanup in the file related to file information retrieval by modifying the handling of device IDs.

  • Removed the unnecessary unsafe block from the extraction of major and minor device IDs.
  • Minor code refactoring to improve code safety.
Comments suppressed due to low confidence (1)

tree/ls_util/entry.rs:705

  • Ensure that calling libc::major and libc::minor without an unsafe block is safe. Confirm that these functions have been reclassified as safe functions, as removing the unsafe block may expose undefined behavior if the functions still require unsafe usage.
let (major, minor) = {

@jgarzik jgarzik merged commit d15e7d8 into main Apr 2, 2025
4 checks passed
@jgarzik jgarzik deleted the cleanups branch April 2, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants