-
Notifications
You must be signed in to change notification settings - Fork 22
Fix typo in conf.py #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in conf.py #170
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
:o help, what did I do wrong? |
|
Nothing you did wrong haha Spec lock file is out of date Could you issue another PR checking what changed and updating the lock file? |
|
Sure! Brb |
66f4641 to
35226f0
Compare
|
Took me a while haha, had to dust off some things with (Also, |
|
Hey @felix91gr -- could you have the spec lock file update be its own PR for traceability purposes? Sorry for the additional hurdle 🙏 |
35226f0 to
5f9c813
Compare
|
@PLeVasseur okay, now I've made this one a descendant of #171's commit, so after 171 gets merged, this one's own commit should follow seamlessly |
|
It seems that maneuver made github a little dizzy. I wonder if it's got to do with a cache not being invalidated... @PLeVasseur does it look like this PR has 2 commits instead of one to you too? |
|
I mean... no worries, I can totally just do this again XD |
5f9c813 to
11b059b
Compare
|
I sent it clean once again. Now, it seems like github understood that the other commit was already in |
|
Weird, it still shows as two commits when viewing on GitHub. Hmm, did a rebase not fix this? |
|
Argh, dang it. One sec. Brb. |
11b059b to
1fedd04
Compare
|
Okay, did a clean 100% new everything from the current |
|
⛵ |
The
subsetanddefecttags had their descriptions swapped with one another. Now they're all good :)