Skip to content

Conversation

@felix91gr
Copy link
Collaborator

The subset and defect tags had their descriptions swapped with one another. Now they're all good :)

@felix91gr felix91gr requested a review from AlexCeleste August 7, 2025 22:36
@netlify
Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 1fedd04
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/689561ea8866c80007bd981d
😎 Deploy Preview https://deploy-preview-170--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@felix91gr
Copy link
Collaborator Author

:o help, what did I do wrong?

@PLeVasseur
Copy link
Collaborator

Nothing you did wrong haha

Spec lock file is out of date

Could you issue another PR checking what changed and updating the lock file?

@felix91gr
Copy link
Collaborator Author

Sure! Brb

@felix91gr felix91gr force-pushed the felix91gr-patch-typo-config_py branch from 66f4641 to 35226f0 Compare August 7, 2025 23:12
@felix91gr
Copy link
Collaborator Author

Took me a while haha, had to dust off some things with rustup and then compile uv. The compiler optimizations at the end took a good 5-10 minutes XD

(Also, uv looks pretty slick!)

@felix91gr felix91gr added the documentation Improvements or additions to documentation label Aug 7, 2025
@PLeVasseur
Copy link
Collaborator

Hey @felix91gr -- could you have the spec lock file update be its own PR for traceability purposes?

Sorry for the additional hurdle 🙏

@felix91gr felix91gr force-pushed the felix91gr-patch-typo-config_py branch from 35226f0 to 5f9c813 Compare August 8, 2025 01:57
@felix91gr
Copy link
Collaborator Author

@PLeVasseur okay, now I've made this one a descendant of #171's commit, so after 171 gets merged, this one's own commit should follow seamlessly

@felix91gr
Copy link
Collaborator Author

It seems that maneuver made github a little dizzy. I wonder if it's got to do with a cache not being invalidated...

@PLeVasseur does it look like this PR has 2 commits instead of one to you too?

@felix91gr
Copy link
Collaborator Author

I mean... no worries, I can totally just do this again XD

@felix91gr felix91gr force-pushed the felix91gr-patch-typo-config_py branch from 5f9c813 to 11b059b Compare August 8, 2025 02:04
@felix91gr
Copy link
Collaborator Author

I sent it clean once again. Now, it seems like github understood that the other commit was already in main

@PLeVasseur
Copy link
Collaborator

Weird, it still shows as two commits when viewing on GitHub.

Hmm, did a rebase not fix this?

@felix91gr
Copy link
Collaborator Author

Argh, dang it. One sec. Brb.

@felix91gr felix91gr force-pushed the felix91gr-patch-typo-config_py branch from 11b059b to 1fedd04 Compare August 8, 2025 02:33
@felix91gr
Copy link
Collaborator Author

Okay, did a clean 100% new everything from the current main. This should work x'D

@PLeVasseur PLeVasseur added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit c522670 Aug 8, 2025
6 checks passed
@felix91gr felix91gr deleted the felix91gr-patch-typo-config_py branch August 8, 2025 02:39
@felix91gr
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants