feat: add uart_sifive #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
duskmoon314
reviewed
May 27, 2025
| const TXWM = 0b01; | ||
| } | ||
|
|
||
| // struct DivRegister: u32 { |
Member
Author
There was a problem hiding this comment.
bitflags 不太支持单个二进制位作为 flag，但是这里保留了每个寄存器的结构用以注释。
实现的话，由于这个寄存器事实上也只用来存放除数，所以需要设置的时候直接调用 set_div 函数即可。
duskmoon314
approved these changes
May 27, 2025
Member
|
后面有些函数的注释可能考虑加一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add
uart_sifivecrate forsifive,uart0deivce.Folloed by manual which is metioned in
READMEfile.Have a simple test on qemu
sifive_udevice: