Expand #[expect] attributes into #[allow]
#4409
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An `#[expect]` outer attribute must not be kept in the `#[automatically_derived]` code, as the expanded code will probably not meet the expectations. Transforming it into the equivalent `#[allow]` attribute is the safest way to ensure that expected attributes will not trigger a warning. Noticed through a bug report entered at the Clippy repository at <rust-lang/rust-clippy#14008>.
samueltardieu
force-pushed
the
push-wxyyqxywtxut
branch
from
def466b to
b83e0d9
Compare
Author
|
Is there anything missing on this PR to make it noticed? |
Author
|
Ping? |
Author
|
Anyone alive here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
#[expect]outer attribute must not be kept in the#[automatically_derived]code, as the expanded code will probably not meet the expectations. Transforming it into the equivalent#[allow]attribute is the safest way to ensure that expected attributes will not trigger a warning.Noticed through a bug report entered at the Clippy repository at rust-lang/rust-clippy#14008.