Skip to content

Conversation

@stslxg-nv
Copy link
Contributor

This change fixes the bug in Issue #219 .
An optional parameter ignore_same_index is added to the end of the parameters list of radius, so that it doesn't break existing codes.
Unit tests are added to test for the bug in non-batched mode and batched mode, and when there are coincident points.

Signed-off-by: Xuangui Huang <xuanguih@nvidia.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (f2d9919) to head (5dc216e).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   97.32%   97.28%   -0.04%     
==========================================
  Files          11       11              
  Lines         224      221       -3     
==========================================
- Hits          218      215       -3     
  Misses          6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit d16c692 into rusty1s:master Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

radius_graph bug: it might produce max_num_neighbors + 1 neighbors for both CPU and GPU versions

3 participants