Skip to content

Conversation

@Novare
Copy link

@Novare Novare commented Jan 16, 2020

This is a "fix" to issue #101. It edits the README to tell users installing this on Windows to add their Visual Studio installation paths to the setup.py. These are then automatically searched during compilation and linking. This fixed all issues related to external libraries on Windows for me.

@codecov-io
Copy link

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #103   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         143    143           
=====================================
  Hits          143    143

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6733f0e...b0e6bc7. Read the comment docs.

@rusty1s
Copy link
Owner

rusty1s commented Jan 16, 2020

Great work, but do we really need to separate between cxx and nvcc for linker arguments?

@Novare
Copy link
Author

Novare commented Jan 16, 2020

Great work, but do we really need to separate between cxx and nvcc for linker arguments?

Probably not, as far as I know only the compilers differ when building C++ or CUDA on Windows, for linking both use link.exe. I think it is more intuitive to differentiate the two since we also have different compile flags for both and it might be neccessary to use different linker flags in the future, but I can unify this to one linker flag list for now if you want to.

@rusty1s
Copy link
Owner

rusty1s commented Jan 16, 2020

I was just curious. Your explanation makes sense. I will merge :)

@rusty1s rusty1s merged commit 2149e81 into rusty1s:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants