-
Notifications
You must be signed in to change notification settings - Fork 203
Build both cpu and gpu binaries #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, I will try to merge by the end of the year. |
|
Hi @rusty1s . Just checking in on this. Let me know if there is anything I can do to help 😄 |
|
I will try to merge this soon. Sorry for the delay. Finally have time to look into it. |
|
Looks like there is indeed no elegant way to allow this behavior without building separate libraries. What a bummer. One solution would be to separate CPU and CUDA functionality in C++ code, but this results in a lot of duplicated code, and we would need to call the correct method in Python dependent on whether we are operating on CUDA or CPU tensors. Nevertheless, I pushed some experimental changes to |
|
I already updated |
|
Thank you! 😃 |
|
Done! Please confirm that it is working as expected. |
|
It's working as expected! Thank you! It feels good to get rid of the private fork and use the official release 😄 |
This way, a docker image containing the GPU package will still run when on a CPU-only machine, as might be the case during testing. This is the same behavior as the pytorch package.