Skip to content

Conversation

@amitt1236
Copy link
Contributor

Added compilation flags for Mac arm (m1 Mac)
Now compiles on my MacBook Pro with the m1 pro chip without any problems.
python3 setup.py install

Note: I imported the platform library, i don't know if you want do depend on that, but its the cleanest
way that I could think about right now.

Copy link
Owner

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Can we fix the linting issues before merging? Also feel free to send a similar PR to torch-scatter.

@rusty1s
Copy link
Owner

rusty1s commented Feb 3, 2022

Thanks. Looks like you also committed .DS_Store. After removing, we can merge :)

@rusty1s rusty1s merged commit d987d29 into rusty1s:master Feb 3, 2022
RexYing pushed a commit to RexYing/pytorch_sparse that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants