used explicit at::Half to __half conversion operator to fix ambiguous… #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conversion error
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 28 28
Lines 1120 1120
=======================================
Hits 810 810
Misses 310 310 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
RexYing
pushed a commit
to RexYing/pytorch_sparse
that referenced
this pull request
Apr 26, 2022
* Add support for PyG GeneralConv * Fix per suggestions * Fix per suggestions * Fix per suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the conversion from at::Half to __half explicit in order to solve the 'ambiguous conversion' problem, when building C++ API