Use macro for __shfl_* functions for ROCm
#296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 71.29% 71.29%
=======================================
Files 25 25
Lines 1066 1066
=======================================
Hits 760 760
Misses 306 306 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rusty1s
approved these changes
Nov 28, 2022
rusty1s
changed the title
__shfl_* functions for ROCm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ROCm dialect of
__shfl_*intrinsic functions, which isn't automatically converted duringhipify.The unit test
test_matmul.pypasses most of the time, occasionally it fails as error exceeds defaultatol, which can happen on both CPU and GPU. Benchmark passes without issue.