fix: harden MCP servers against injection and CORS bypass#213
Merged
Conversation
…rototype pollution - Sanitize shell arguments in hooks_init, hooks_pretrain, hooks_build_agents, and workers_status handlers to prevent OS command injection (CWE-78) - Strengthen sanitizeShellArg to also strip quotes, newlines, and backslashes - Add sanitizeNumericArg helper for numeric-typed arguments - Improve validateRvfPath with symlink resolution (realpathSync) and cwd confinement - Add schema validation and prototype pollution guard to hooks_import handler - Replace permissive CORS (CorsLayer::permissive) with localhost-only origin policy in Rust SSE transport Co-Authored-By: claude-flow <ruv@ruv.net>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execSync()call sites inmcp-server.jsthat passed user-controlled args (hooks_init, hooks_pretrain, hooks_build_agents, workers_status) without sanitizationCorsLayer::permissive()in Rust SSE transport with localhost-only origin policy__proto__/constructor/prototypeguard tohooks_importhandlervalidateRvfPath()withrealpathSync()symlink resolution and cwd confinementsanitizeShellArg()to also strip quotes, newlines, and backslashes; addedsanitizeNumericArg()helperFindings addressed
Test plan
cargo check -p ruvector-clipassesbuild_agentsarg is sanitized__proto__keys🤖 Generated with claude-flow