Skip to content

Comments

Updated dockerfile.#293

Merged
rvirding merged 1 commit intolfe:developfrom
oubiwann:update-docker
Nov 23, 2016
Merged

Updated dockerfile.#293
rvirding merged 1 commit intolfe:developfrom
oubiwann:update-docker

Conversation

@oubiwann
Copy link
Member

This was used to update the lfex/lfe and lfex/lfe-docs Dockerhub images. In
addition to some minor cleanup, it did the following:

  • Upgraded the dockerfile to use Erlang 19.1
  • Upgraded LFE to use the latest dev version, 1.3-dev

@rvirding
Copy link
Member

rvirding commented Nov 15, 2016

Could you please rebase this and I will pull it.

@yurrriq
Copy link
Contributor

yurrriq commented Nov 15, 2016

Any interest in an Alpine-based image? I've got one lying around.

@rvirding
Copy link
Member

What is an Alpine-based image?

This was used to update the lfex/lfe and lfex/lfe-docs Dockerhub images. In
addition to some minor cleanup, it did the following:

* Upgraded the dockerfile to use Erlang 19.1
* Upgraded LFE to use the latest dev version, 1.3-dev
@oubiwann
Copy link
Member Author

@rvirding Done!

@yurrriq It would probably make sense for other changes to the Dockerfile to go in a separate PR ...

@oubiwann
Copy link
Member Author

@yurrriq Actually, there's already a project that tracks miscellaneous LFE docker images:

That might be the best place for the Alpine-based image...

@yurrriq
Copy link
Contributor

yurrriq commented Nov 16, 2016

Cool!

@oubiwann
Copy link
Member Author

@rvirding Would you rather we simplify the LFE repo, and remove the Dockerfile and docker-related make targets? We could make an entry in the README pointing to Dockerhub and the lfex/dockerfiles repo ...

@rvirding
Copy link
Member

No, not really. I have nothing against having it there. I just wasn't aware that you had to do specific dockers for different systems (logical really) and then just wondered why we have one and not many. Also when we get olp working and standard then the problem should be moved there in some way.

@rvirding rvirding merged commit 1023ef8 into lfe:develop Nov 23, 2016
@rvirding
Copy link
Member

I clicked the squash and merge button by mistake so the original branch has not been removed. Sorry about that.

You will have to remove the original branch to get rid of it.

oubiwann added a commit that referenced this pull request Jul 26, 2020
This was used to update the lfex/lfe and lfex/lfe-docs Dockerhub images. In
addition to some minor cleanup, it did the following:

* Upgraded the dockerfile to use Erlang 19.1
* Upgraded LFE to use the latest dev version, 1.3-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants