Skip to content

Conversation

@danowar2k
Copy link

This fixes #157. The comment editor is preloaded, so the following errors just don't happen, it seems. Before the fix when one selected "select mode" the old rectangle without any attached comments stayed, with the fix a comment-less rectangle is removed.

This probably helps preventing the other errors.

You should probably (easy to say, I know) move to another modern PDF annotation library...? ;-)

@Amrita1991
Copy link
Contributor

Thank you for the pull request. It corrects the console error log. However, while testing I found that there are actuially some more console errors that comes up(not because of this change). Hence I have decided to correct as many of them as possible and then release a new version that will have these changes. So you need to wait till them to see your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1.5.8] [Moodle 4.4.9/4.5.6] [PHP 8.1] Console errors on mobile when using rectangle comment mode

2 participants