Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds an Xcode Cloud post-clone script intended to auto-stamp app version/build numbers during CI builds, and also includes several UX/marketing updates across the website and ChatKit UI.
Changes:
- Add
ci_scripts/ci_post_clone.shto stampMARKETING_VERSIONfromCI_TAGandCURRENT_PROJECT_VERSIONfromCI_BUILD_NUMBER. - Update website “Mobile Companion” section with new screenshots, copy, hover/scroll animations.
- Improve ChatKit scrolling performance by disabling Textual text selection while the message list is actively scrolling; remove
UIBackgroundModesprocessingfrom the mobile Info.plist.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/app/page.tsx | Adds mobile companion screenshots, copy updates, and new CSS hooks for animations/hover effects. |
| website/app/globals.css | Adds scroll-driven reveal animations for the mobile companion section with reduced-motion and non-support fallbacks. |
| RxCodeMobile/Info.plist | Removes processing background mode. |
| Packages/Sources/RxCodeChatKit/MessageListView.swift | Tracks scroll phase and exposes scroll activity via environment to downstream rows. |
| Packages/Sources/RxCodeChatKit/MarkdownView.swift | Adds environment key + modifier to disable Textual selection overlay while scrolling. |
| ci_scripts/ci_post_clone.sh | New Xcode Cloud post-clone version stamping + Xcode defaults tweaks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Repo root: $REPO_ROOT" | ||
|
|
||
| # Xcode plugin/macro validation often blocks CI for SPM dependency plugins. | ||
| defaults write com.apple.dt.Xcode IDESkipPackagePluginFingerprintValidatation -bool YES || true |
Comment on lines
+28
to
+30
| echo "Stamping MARKETING_VERSION from CI_TAG: $CI_TAG -> $VERSION" | ||
| sed -i '' "s/MARKETING_VERSION = [^;]*;/MARKETING_VERSION = $VERSION;/g" "$PROJECT_FILE" | ||
|
|
Comment on lines
+3
to
+9
| # Xcode Cloud post-clone hook for RxCodeMobile | ||
| # - Stamps the app version from the git tag (CI_TAG -> MARKETING_VERSION) | ||
| # - Sets the build number from CI_BUILD_NUMBER (CURRENT_PROJECT_VERSION) | ||
| # | ||
| # Xcode Cloud runs this script automatically right after cloning the repo. | ||
| # Configure the Xcode Cloud workflow to start a build on new tag creation; | ||
| # CI_TAG and CI_BUILD_NUMBER are then provided by Xcode Cloud. |
Contributor
Author
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.