fix: add animation transition to chat message on mobile#41
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Pull request overview
This PR updates the mobile chat experience by adding a dedicated “thread loading” overlay (with animated skeleton UI) and adjusting navigation so the Briefing tab’s chat can be dismissed/popped correctly while preserving smoother transitions on iPhone.
Changes:
- Add
MobileThreadLoadingOverlayand show it inMobileChatViewwith an animated transition while a thread’s initial messages refresh. - Track per-session “initial thread messages loading” state in
MobileAppState(loadingThreadMessageSessions) and clear it when initial snapshots arrive. - Refine iPhone Briefing navigation to use a path-bound
NavigationStackand introduce a helper to avoid unwanted cross-navigation when already in briefing detail.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RxCodeMobile/Views/RootView.swift | Uses a path-bound briefing NavigationStack, wires a close callback through Briefing → Chat, and refines “open active session” gating. |
| RxCodeMobile/Views/MobileThreadLoadingOverlay.swift | New SwiftUI loading overlay with animated skeleton placeholders and reduce-motion support. |
| RxCodeMobile/Views/MobileChatView.swift | Shows the new loading overlay with transitions and adds a 1s minimum display gate. |
| RxCodeMobile/Views/MobileBriefingView.swift | Passes a close callback into MobileChatView when opened from Briefing and hides the tab bar in chat. |
| RxCodeMobile/State/MobileAppState+Intents.swift | Adds isLoadingThreadMessages, updates subscribe flow to set/clear loading state, and clears loading state on archive/delete. |
| RxCodeMobile/State/MobileAppState+Inbound.swift | Clears/renames loading state when snapshots arrive or session IDs change. |
| RxCodeMobile/State/MobileAppState.swift | Adds new published set tracking sessions whose initial message window is still loading. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @Published var loadingMoreSessions: Set<String> = [] | ||
| /// Sessions whose initial message page is being refreshed after opening the | ||
| /// chat detail view. | ||
| @Published var loadingThreadMessageSessions: Set<String> = [] |
Comment on lines
375
to
377
| /// view is driven by `selectedSession`. Keeping the two mechanisms separate | ||
| /// avoids pushing the same chat page twice. | ||
| private func navigate(toSession sessionID: String, projectID: UUID?) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.