Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the CI version-bumping script to correctly target the RxCode app’s bundle identifier and adjust the Xcode project’s MARKETING_VERSION accordingly.
Changes:
- Add an explicit
BUNDLE_IDENTIFIERand use it when updatingMARKETING_VERSION. - Rewrite the awk logic to update within full
buildSettingsblocks rather than relying on adjacent-line assumptions. - Update
MARKETING_VERSIONvalues in the Xcode project for Debug/Release configurations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/ci/update-version.sh | Targets the correct bundle identifier and updates MARKETING_VERSION by parsing full build settings blocks. |
| RxCode.xcodeproj/project.pbxproj | Updates the app target’s MARKETING_VERSION values (Debug/Release). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Updating MARKETING_VERSION to $VERSION in $PROJECT_FILE for $BUNDLE_IDENTIFIER" | ||
|
|
||
| # Create a temporary file | ||
| TMP_FILE=$(mktemp) |
Comment on lines
+62
to
+69
| END { | ||
| if (in_build_settings) { | ||
| printf "%s", block | ||
| } | ||
| if (updated_count == 0) { | ||
| exit 1 | ||
| } | ||
| } |
Contributor
Author
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.