feat: add i18n support to mobile app#50
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds localization infrastructure and begins migrating user-facing strings in the iOS app to String Catalog–backed localized strings, while also cleaning up legacy .strings resources in favor of .xcstrings.
Changes:
- Replaced several hard-coded mobile UI/error strings with
String(localized:)(including interpolated messages). - Added
RxCodeMobile/Resources/Localizable.xcstringswithen+zh-Hansentries for mobile. - Removed legacy
.lproj/Localizable.stringsfiles for the macOS app +RxCodeChatKit, and registered"zh-Hans"as a known region in the Xcode project.
Reviewed changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RxCodeMobile/Views/OnboardingView.swift | Localizes QR/pairing error strings surfaced during onboarding. |
| RxCodeMobile/Views/MobileSettingsView.swift | Localizes multiple settings labels/captions and adds a localized archive retention label helper. |
| RxCodeMobile/Views/MobileInputBar.swift | Localizes the chat input placeholder (streaming vs idle). |
| RxCodeMobile/State/MobileAppState+Sync.swift | Localizes run-profile related error strings. |
| RxCodeMobile/State/MobileAppState+RemoteConfig.swift | Localizes remote-config and skill/agent/MCP error strings. |
| RxCodeMobile/State/MobileAppState+Pairing.swift | Localizes pairing failure messages. |
| RxCodeMobile/State/MobileAppState+Inbound.swift | Localizes fallback inbound-operation error strings. |
| RxCodeMobile/Resources/Localizable.xcstrings | Adds the mobile app’s string catalog (including zh-Hans translations). |
| RxCode/Resources/ko.lproj/Localizable.strings | Removes legacy strings file (migration to string catalog workflow). |
| RxCode/Resources/en.lproj/Localizable.strings | Removes legacy strings file (migration to string catalog workflow). |
| Packages/Sources/RxCodeChatKit/Resources/ko.lproj/Localizable.strings | Removes legacy strings file (migration to string catalog workflow). |
| Packages/Sources/RxCodeChatKit/Resources/en.lproj/Localizable.strings | Removes legacy strings file (migration to string catalog workflow). |
| RxCode.xcodeproj/xcshareddata/xcschemes/RxCode.xcscheme | Sets scheme launch language to zh-Hans. |
| RxCode.xcodeproj/project.pbxproj | Adds "zh-Hans" to knownRegions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| language = "zh-Hans" |
Comment on lines
+371
to
+376
| private func archiveRetentionLabel(days: Int) -> String { | ||
| if days == 1 { | ||
| String(localized: "Archive after \(days) day") | ||
| } else { | ||
| String(localized: "Archive after \(days) days") | ||
| } |
Contributor
Author
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.