fix: mobile thread jump#63
Merged
Merged
Conversation
…rkspace/xcshareddata/swiftpm/Package.resolved and related files
- remove redundant activeSessionID assignment - ensure activeSessionID is properly handled without navigation commands - update MobileAppState+Inbound.swift to reflect changes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates mobile snapshot handling to avoid unintended thread navigation, adjusts permission prompts to wait indefinitely, and adds responsiveness improvements for shell path prewarming, stream setup, and todo snapshot UI refreshes.
Changes:
- Guards mobile
activeSessionIDadoption during snapshots to reduce thread jumps. - Removes
PermissionServertimeout-denial behavior and lets UI prompts remain pending. - Adds shell PATH prewarm, concurrent pre-spawn work, and todo snapshot revision invalidation.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
RxCodeMobile/State/MobileAppState+Inbound.swift |
Updates iOS snapshot active-session adoption behavior. |
RxCodeAndroid/app/src/main/java/app/rxlab/rxcode/state/MobileAppState.kt |
Updates Android snapshot active-session adoption behavior. |
RxCode/Views/Toolbar/TodoProgressToolbarItem.swift |
Reads todo snapshot revision to refresh SwiftData-backed todos. |
RxCode/Services/PermissionServer.swift |
Removes permission prompt timeout tasks and denial fallback. |
RxCode/Services/IDEServer/AppState+IDEToolHandling.swift |
Bumps todo snapshot revision after IDE todo writes. |
RxCode/Services/CodexAppServer+Process.swift |
Adds Codex environment prewarm helper. |
RxCode/Services/ClaudeService+Discovery.swift |
Adds Claude shell PATH prewarm helper. |
RxCode/Services/ACPService+Spawn.swift |
Adds ACP environment prewarm helper. |
RxCode/App/AppState+Stream.swift |
Bumps todo snapshot revision after streamed TodoWrite persistence. |
RxCode/App/AppState+Lifecycle.swift |
Starts backend shell PATH cache prewarming during initialization. |
RxCode/App/AppState+CrossProject.swift |
Runs pre-spawn setup concurrently and bumps revision for Codex todo snapshots. |
RxCode/App/AppState.swift |
Adds observable todo snapshot revision counter. |
RxCode.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved |
Updates SwiftPM origin hash only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| active != null && | ||
| currentActive != null && | ||
| isDraftSessionId(currentActive) && | ||
| nextRedirects[currentActive] == active |
Comment on lines
+437
to
+439
| /// The first requester emits to the UI stream; CLI retries — issued every time the | ||
| /// CLI's own HTTP hook timeout expires — join the same entry by appending another | ||
| /// continuation, so the eventual answer reaches whichever HTTP connection is live. |
Contributor
Author
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RxCode — fix-mobile-thread-jump
PermissionServer.swiftto handle prompt waiting indefinitely.bngzczst6completed.