Skip to content

Conversation

@jvgomg
Copy link
Contributor

@jvgomg jvgomg commented Jan 2, 2018

I got an error in my create-react-app application about unresolved dependencies for react-dom. React and React DOM should be peer dependencies nine times out of ten.

I have moved react-dom to package.json’s peerDependencies.

@ryanhefner ryanhefner merged commit 515e9fc into ryanhefner:master Jan 5, 2018
@ryanhefner
Copy link
Owner

Thanks! Definitely the way to go. I’m going to go back through my other repos and make sure I move that to the peers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants