Skip to content

Conversation

@ryanlua
Copy link
Owner

@ryanlua ryanlua commented Jan 13, 2025

Description

Adds a new argument to start an interactive login with Instaloader.

Related Issues

Closes #16

Changes Made

  • Add new --login argument which takes a username
  • Update previous arguments to use argparse metavar when needed
  • Add logic for logging in using Instaloader with interactive_login()

Checklist

  • I have tested these changes thoroughly.
  • I have reviewed my code for any potential errors or issues.
  • I have followed the code style guidelines for this project.

Additional Notes

Related to https://github.com/RyanLua/InstaWebhooks/discussions/15

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
@ryanlua ryanlua added the enhancement New feature or request label Jan 13, 2025
@ryanlua ryanlua self-assigned this Jan 13, 2025
@github-actions
Copy link

github-actions bot commented Jan 13, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@ryanlua ryanlua marked this pull request as ready for review January 13, 2025 22:26
Copilot AI review requested due to automatic review settings January 13, 2025 22:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/instawebhooks/parser.py:52

  • [nitpick] The help message could be more descriptive. Suggest updating it to: 'login to Instagram with username, starting an interactive login session.'
help="login to instagram with username"

Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
@ryanlua ryanlua requested a review from Copilot January 13, 2025 22:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/instawebhooks/main.py:58

  • The error message is vague. Consider specifying the type of error that occurred during login.
An error happened during login. Check if the provided username exists.

src/instawebhooks/main.py:48

  • The new login functionality should be covered by tests to ensure it works as expected.
if args.login or args.interactive_login:

Signed-off-by: Ryan Luu <ryan.luu@ryanluu.dev>
@ryanlua ryanlua merged commit 56294ea into main Jan 13, 2025
10 checks passed
@ryanlua ryanlua deleted the login-arg branch January 13, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11/08/2024 09:52:27 AM - CRITICAL - instaloader: error: Redirected to login page. Use --login or --load-cookies. Not logged into Instaloader

2 participants