Skip to content

fixing proper use of exp in generateKeyPair(b, exp) and tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2014
Merged

fixing proper use of exp in generateKeyPair(b, exp) and tests #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NodeRSA.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ module.exports = (function() {
*/
NodeRSA.prototype.generateKeyPair = function(bits, exp) {
bits = bits || 2048;
exp = 65537;
exp = exp || 65537;

if (bits % 8 != 0) {
if (bits % 8 !== 0) {
throw Error('Key size must be a multiple of 8.');
}

Expand Down
10 changes: 9 additions & 1 deletion test/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,17 @@ describe("NodeRSA", function(){
describe("Generating keys", function() {
for (var size in keySizes) {
(function(size){
it("should make key pair " + size.b + "-bit length and public exponent is " + (size.e || 65537), function () {
it("should make key pair " + size.b + "-bit length and public exponent is " + size.e, function () {
generatedKeys.push(new NodeRSA({b: size.b, e: size.e}));
assert.instanceOf(generatedKeys[generatedKeys.length - 1].keyPair, Object);

if (size.e != null && size.e != undefined)
{
assert.equal(generatedKeys[generatedKeys.length - 1].keyPair.e, size.e);
} else {
assert.equal(generatedKeys[generatedKeys.length - 1].keyPair.e, 65537);
}

assert.equal(generatedKeys[generatedKeys.length - 1].getKeySize(), size.b);
assert.equal(generatedKeys[generatedKeys.length - 1].getMaxMessageSize(), (size.b / 8 - 11));
});
Expand Down