Skip to content
This repository was archived by the owner on Jul 18, 2020. It is now read-only.

Conversation

@freeranger
Copy link

@tansaku
Copy link
Contributor

tansaku commented Jan 25, 2016

wow, that's a real corner case ... how many people will have cookies disabled for that domain?

Is it worth adding this if only 1 in a thousand will encounter it @freeranger ?

@freeranger
Copy link
Author

@tansaku Granted there may not be that many people who are so security conscious, but given that it can happen, why not mention it in the notes?
One less thing for people to try to figure out why things aren't working for them....

@tansaku
Copy link
Contributor

tansaku commented Jan 25, 2016

because for everyone who doesn't have to deal with it then it's an extra thing for them to read that makes the homework more daunting.

I think I'd be more comfortable with a footnote - or a troubleshooting section that mentioned it to avoid the main description become too bloated ...

@freeranger
Copy link
Author

Fair point, though if they don't understand about cookies, what are they doing on a web course (part 2)? :)
I didn't really want to whack it in the main body of the text but there didn't seem to be anywhere else useful to put it - a footnote on that particular page of the instructions "wizard"?
Or some footnotes right at the end? But I haven't gotten that far because it barfed when I opened Heroku, so I'm not looking to the next page...

Maybe a separate "troubleshooting" file in the repo...but how do they get sight of that easily?

@tansaku
Copy link
Contributor

tansaku commented Jan 25, 2016

yeah I think a separate troubleshooting file, and we link to that at beginning and end; however I don't think that we need to worry too much about that being in site.

I'm not saying they won't understand cookies - just that we want to avoid bloat on items that will only benefit 1 in a 1000. Of course if I'm wrong and 90% of folks encounter this that's another thing. However assuming this is for 1 in a 1000 thing I think we should avoid verbiage for the other 999 who will appreciate brevity wherever possible I think ...

@freeranger
Copy link
Author

Ok I'll redo it in a separate file - it will be a bit lonely though coz I don't have any other troubleshooting tips to share ;)

Do you want to reject the pull request and I will do another or what?

On 25 Jan 2016, at 12:11, Sam Joseph notifications@github.com wrote:

yeah I think a separate troubleshooting file, and we link to that at beginning and end; however I don't think that we need to worry too much about that being in site.

I'm not saying they won't understand cookies - just that we want to avoid bloat on items that will only benefit 1 in a 1000. Of course if I'm wrong and 90% of folks encounter this that's another thing. However assuming this is for 1 in a 1000 thing I think we should avoid verbiage for the other 999 who will appreciate brevity wherever possible I think ...


Reply to this email directly or view it on GitHub.

@tansaku
Copy link
Contributor

tansaku commented Feb 9, 2016

@freeranger you could re-use this pull request if you liked by dumping the old commit and starting a new one - that way we keep all the related discussion?

@tansaku
Copy link
Contributor

tansaku commented Jul 18, 2016

@freeranger - were you going to add to this PR? If you want to open another that's fine - I'll close and work from the other

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants