Feedback on PR #372 #388
Merged
Feedback on PR #372 #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: getChainCount function to compute the count on its own refactor: query comptroller address from sdk chore: update words on the governance page refactor: create snippet for deployment note
smol-ninja
changed the title
andreivladbrg
approved these changes
Oct 22, 2025
remove redundant check from ComptrollersTable
smol-ninja
added a commit
that referenced
this pull request
Oct 22, 2025
* bump sdk * add latest contract deployments * bump sdk * feat: comptrollers table refactor: hardcode values instead of making rpc calls refactor: update governance page * refactor: update supported chains chore: add PR NOTEs * chore: nitpick * bump sablier * chore: add todo about reference links chore: bump deps * chore: fix deps * Feedback on PR #372 (#388) * feat: add getLatestLockupChainIds helper function refactor: getChainCount function to compute the count on its own refactor: query comptroller address from sdk chore: update words on the governance page refactor: create snippet for deployment note * capitalize comptroller remove redundant check from ComptrollersTable --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
andreivladbrg
added a commit
that referenced
this pull request
Oct 23, 2025
* bump sdk * add latest contract deployments * bump sdk * feat: comptrollers table refactor: hardcode values instead of making rpc calls refactor: update governance page * refactor: update supported chains chore: add PR NOTEs * chore: nitpick * bump sablier * chore: add todo about reference links chore: bump deps * chore: fix deps * Feedback on PR #372 (#388) * feat: add getLatestLockupChainIds helper function refactor: getChainCount function to compute the count on its own refactor: query comptroller address from sdk chore: update words on the governance page refactor: create snippet for deployment note * capitalize comptroller remove redundant check from ComptrollersTable --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
andreivladbrg
added a commit
that referenced
this pull request
Oct 23, 2025
* update custom deployments page (#382) * update custom deployments page * remove just as requirement from custom deployments * andrei's feedback * add step 4 for comptroller --------- Co-authored-by: Andrei Vlad Birgaoanu <andreivladbrg@gmail.com> * style: add overrides for md and mdx * refactor: flow status page (#386) * chore: use snapshot time instead of start time in Stream characteristics table * Bump sdk and update governance page (#372) * bump sdk * add latest contract deployments * bump sdk * feat: comptrollers table refactor: hardcode values instead of making rpc calls refactor: update governance page * refactor: update supported chains chore: add PR NOTEs * chore: nitpick * bump sablier * chore: add todo about reference links chore: bump deps * chore: fix deps * Feedback on PR #372 (#388) * feat: add getLatestLockupChainIds helper function refactor: getChainCount function to compute the count on its own refactor: query comptroller address from sdk chore: update words on the governance page refactor: create snippet for deployment note * capitalize comptroller remove redundant check from ComptrollersTable --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com> * feat: add contract references (#383) * docs: add contract references and update autogen script using Claude * fix: add evm-utils to gitmodules script: update autogen to deal with malformed code block endings with asterisks * feat: add concepts section for variable claim airdrop (#387) * feat: add concepts section for variable claim airdrop * update diagrams and add VCA campaign update access control and add claimTo and ClaimViaSig * andrei's suggestion * docs: add use cases for VCA airdrop docs: use claimTo in VCA diagram docs: add compatibility column to airdrops access control * refactor: update lockup examples with latest version (#391) * refactor: update lockup examples with latest version refactor: update example GH url links refactor: remove staking page * change type import * fix conflicts --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com> * revert from warn to throw * refactor: update airdrops examples (#392) * refactor: update airdrops examples * refactor: hide campaign verifiction page * chore: wordings * fix formatting --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com> * fix formatting * fix: broken links * refactor: update flow examples * fix: broke links * remove Broker from flow example * update lockfile * fix: vercel issue --------- Co-authored-by: Shubham Yadav <shubhamy2015@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also closes #374
Commits
feat: add getLatestLockupChainIds helper function
refactor: getChainCount function to compute the count on its own
refactor: query comptroller address from sdk
chore: update words on the governance page
refactor: create snippet for deployment note