Skip to content

Revert "Add coverage for OAuth discovery redirects and refresh tokens" #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

Revert "Add coverage for OAuth discovery redirects and refresh tokens" #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions tests/unit/client/test_oauth2_providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,32 +539,6 @@ async def test_client_credentials_request_token_stops_on_server_error(
assert provider._metadata is None


@pytest.mark.anyio
async def test_client_credentials_request_token_stops_on_redirect(
monkeypatch: pytest.MonkeyPatch,
) -> None:
storage = InMemoryStorage()
client_metadata = OAuthClientMetadata(redirect_uris=_redirect_uris(), scope="alpha")
provider = ClientCredentialsProvider("https://api.example.com/service", client_metadata, storage)

metadata_responses = [_make_response(302)]
registration_response = _make_response(200, json_data=_registration_json())
token_response = _make_response(200, json_data=_token_json("alpha"))

clients = [
DummyAsyncClient(send_responses=metadata_responses),
DummyAsyncClient(send_responses=[registration_response]),
DummyAsyncClient(post_responses=[token_response]),
]
monkeypatch.setattr("mcp.client.auth.oauth2.httpx.AsyncClient", AsyncClientFactory(clients))

await provider._request_token()

assert storage.tokens is not None
assert storage.tokens.scope == "alpha"
assert provider._metadata is None


@pytest.mark.anyio
async def test_client_credentials_ensure_token_returns_when_valid() -> None:
storage = InMemoryStorage()
Expand Down
27 changes: 0 additions & 27 deletions tests/unit/server/auth/test_token_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,33 +256,6 @@ async def test_handle_route_refresh_token_branch() -> None:
assert payload["access_token"] == "refreshed-token"


@pytest.mark.anyio
async def test_handle_route_refresh_token_without_scope() -> None:
provider = RefreshTokenProvider()
client_info = OAuthClientInformationFull(
client_id="client",
grant_types=["refresh_token"],
scope="alpha",
)
handler = TokenHandler(
provider=cast(OAuthAuthorizationServerProvider[Any, Any, Any], provider),
client_authenticator=cast(ClientAuthenticator, DummyAuthenticator(client_info)),
)

request_data = {
"grant_type": "refresh_token",
"refresh_token": "refresh-token",
"client_id": "client",
"client_secret": "secret",
}

response = await handler.handle(cast(Request, DummyRequest(request_data)))

assert response.status_code == 200
payload = json.loads(bytes(response.body).decode())
assert payload["access_token"] == "refreshed-token"


@pytest.mark.anyio
async def test_handle_route_refresh_token_invalid_scope() -> None:
provider = RefreshTokenProvider()
Expand Down