Make RecursivelyEnumeratedSet_forest a subclass of RecursivelyEnumeratedSet_generic

[seblabbe]

As a follow up of #16351, we integrate the class RecursivelyEnumeratedSet_forest as a subclass of RecursivelyEnumeratedSet_generic implementing the following change:

-class RecursivelyEnumeratedSet_forest(Parent):
+class RecursivelyEnumeratedSet_forest(RecursivelyEnumeratedSet_generic):

and consequential changes.

I was hoping this to be enough to activate few methods like to_digraph from the generic class that I like to use but are currently not available for the forest type. But unfortunately, the implementation of breadth first search for forest type does not yet take into account the max_depth argument. That will be dealt in another ticket.

CC: @tscrim

Component: combinatorics

Author: Sébastien Labbé

Branch/Commit: u/slabbe/30238 @ 7b65a95

Issue created by migration from https://trac.sagemath.org/ticket/30238

[seblabbe]

Commit: d180dc5

[seblabbe]

Branch: u/slabbe/30238

[seblabbe]

New commits:

2b310e8	first change
d180dc5	30238:Make RecursivelyEnumeratedSet_forest a subclass of RecursivelyEnumeratedSet_generic

[seblabbe]

comment:2

Note: I am changing the ordering of the input of the init method of RecursivelyEnumeratedSet_forest to match the one of RecursivelyEnumeratedSet_generic. This might break code using RecursivelyEnumeratedSet_forest if such code exists. One option is to make this ticket less intrusive by preserving the previous ordering for the init of RecursivelyEnumeratedSet_forest.

This is transparent for the code based on the function RecursivelyEnumeratedSet. The problem was only if people were using directly RecursivelyEnumeratedSet_forest.

[mkoeppe]

comment:3

patchbot indicates doctest failures

[seblabbe]

comment:4

ok, I will work on that.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

41aaa0a	30238: fix pycodestyle in map_reduce.py
cc0b7ae	30238: adapt sage library code with the algorithm->enumeration change

[sagetrac-git]

Changed commit from d180dc5 to cc0b7ae

[seblabbe]

comment:6

I am changing the status to needs review just to see what the patchbot says. Locally, I still have at least the following issues, but I did not tested the whole library.

----------------------------------------------------------------------
sage -t --random-seed=0 combinat/subsets_pairwise.py  # 1 doctest failed
sage -t --random-seed=0 combinat/posets/hasse_diagram.py  # 2 doctests failed
----------------------------------------------------------------------