Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong substitution implementation for fraction fields #7150

Closed
novoselt opened this issue Oct 8, 2009 · 3 comments
Closed

Wrong substitution implementation for fraction fields #7150

novoselt opened this issue Oct 8, 2009 · 3 comments

Comments

@novoselt
Copy link
Member

novoselt commented Oct 8, 2009

I am getting this in 4.1.1 and find it really frustrating (especially since it took me several hours to catch):

sage: QQ["x", "y"].inject_variables()
Defining x, y
sage: e1 = x^2*y^3 - x^2*y - x*y
sage: e2 = e1.parent().fraction_field()(e1)
sage: print e2
x^2*y^3 - x^2*y - x*y
sage: print e2.subs(y=SR("s"))
x^2*s^3 - (x^2 - x)*s

The last line is wrong!

CC: @williamstein

Component: symbolics

Issue created by migration from https://trac.sagemath.org/ticket/7150

@novoselt novoselt added this to the sage-4.2 milestone Oct 8, 2009
@sagetrac-fwclarke
Copy link
Mannequin

sagetrac-fwclarke mannequin commented Oct 8, 2009

comment:1

But in 4.1.2.rc0:

sage: QQ["x", "y"].inject_variables()
Defining x, y
sage: e1 = x^2*y^3 - x^2*y - x*y
sage: e2 = e1.parent().fraction_field()(e1)
sage: print e2
x^2*y^3 - x^2*y - x*y
sage: print e2.subs(y=SR("s"))
s^3*x^2 - s*x^2 - s*x

So the problem may already have been solved.

@sagetrac-fwclarke sagetrac-fwclarke mannequin modified the milestones: sage-4.2, sage-4.1.2 Oct 8, 2009
@williamstein williamstein modified the milestones: sage-4.1.2, sage-4.2 Oct 10, 2009
@jasongrout
Copy link
Member

comment:3

This may need to be closed with 4.1.2.

@mwhansen
Copy link
Contributor

comment:4

Yep, I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants