-
-
Notifications
You must be signed in to change notification settings - Fork 674
use the finer new categories for some lattice posets in library #40705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview for this PR (built with commit c27cba6; changes) is ready! 🎉 |
b2b07eb
to
df3a3af
Compare
one question : should I add doctests for all these enhanced categories ? |
I think it might be good to have, for each of the categories, something like I realize that I don't understand something. I did
and indeed, trace confirms that this is not picking up the method from |
I was thinking of adding tests to check that each poset where we declare a specific category is in this category. This may seem superfluous, as there can be no failure, otherwise the init would fail. yes, the category always have a very low priority. moving the "is_congruence_uniform" and similar method to the category would be a possible next step in the future |
But then, why is there a method 'is_congruence_uniform' if it is not used? |
It will become used once the method in "LatticePoset" will be moved to the general category of lattices. I plan to do that later. |
I think having a _test_congruence_uniform etc would be good idea. Can we already iterate over the posets of given size in a given category? Then checking the number of posets against the Oeis is also an obvious candidate. |
thanks for the suggestions, Martin. Maybe we can keep them for another PR ? Here the aim is just to put some existing examples in more refined categories. |
Bien sur ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
namely declare some known properties as categories, as allowed by #39554
📝 Checklist