sage.rings.polynomial.polynomial_singular_interface: drop unused import #40879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the import of sage.rings.finite_rings.finite_field_constructor from this file, since it is unused. I noticed this because it leads to circular imports: $ python Python 3.13.7 (main, Aug 22 2025, 06:36:41) [GCC 15.2.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from sage.rings.function_field.constructor import FunctionField >>> from sage.rings.integer import Integer >>> from sage.rings.rational_field import QQ >>> K = FunctionField(QQ, 'x') Traceback (most recent call last): ... ImportError: cannot import name PolynomialRing_generic (The unneccessary import from sage.rings.integer is due to another, harder instance of this problem.)
tobiasdiez
approved these changes
Sep 24, 2025
|
It will be a painstaking process. I'm sure many instances are careless choices that had no impact at the time because everyone was using I don't know why it became fatal today, but these errors are new for me I think. I made a post to sage-devel a moment ago. |
|
Documentation preview for this PR (built with commit 123625f; changes) is ready! 🎉 |
|
The macos gods look upon us with favor today. The CI is all the way green. Tagging w/ positive review, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the import of
sage.rings.finite_rings.finite_field_constructorfrom this file, since it is unused. I noticed this because it leads to circular imports:(The unneccessary import from
sage.rings.integeris due to another, harder instance of this problem.)