more usage of enumerate() #40916
Merged
more usage of enumerate() #40916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 6d4d7bf; changes) is ready! 🎉 |
mantepse
reviewed
Sep 29, 2025
mantepse
reviewed
Sep 29, 2025
by using join at the end Co-authored-by: Martin Rubey <axiomize@yahoo.de>
mantepse
reviewed
Sep 30, 2025
| return "0" | ||
|
|
||
| s = " + ".join(terms) | ||
| return s.replace("+ -", "- ") |
There was a problem hiding this comment.
the following lines should be removed, and there is whitespace. Sorry, that's an artefact of how github suggestions do not work :-(
There was a problem hiding this comment.
indeed.. now fixed
|
Danke schön ! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 5, 2025
sagemathgh-40916: more usage of enumerate() as suggested by `ruff check --select=SIM113` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40916 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as suggested by
ruff check --select=SIM113📝 Checklist