Skip to content

Workaround for linbox charpoly/minpoly issues, take 2 #40975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
+2 −2
Merged

Workaround for linbox charpoly/minpoly issues, take 2 #40975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sage/matrix/matrix_integer_dense.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,7 @@ cdef class Matrix_integer_dense(Matrix_dense):
sig_on()
linbox_fmpz_mat_charpoly(g._poly, self._matrix)
sig_off()
if g.lc() == 1:
if g.lc() == 1 and g.degree() == self._nrows:
break
elif algorithm == 'generic':
g = Matrix_dense.charpoly(self, var)
Expand Down
2 changes: 1 addition & 1 deletion src/sage/matrix/matrix_integer_sparse.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ cdef class Matrix_integer_sparse(Matrix_sparse):
fmpz_poly_set_coeff_mpz(g._poly, i, tmp)
_fmpz_poly_set_length(g._poly, p.size())

if g.lc() == 1:
if g.lc() == 1 and g.degree() == self._nrows:
break

del M
Expand Down
Loading