Skip to content

Removed extra unit tests - speeds up the unit tests from 3.5 minutes to less than 60 seconds #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

Removed extra unit tests - speeds up the unit tests from 3.5 minutes to less than 60 seconds #118

merged 1 commit into from
Oct 6, 2020

Conversation

@kmcquade
Copy link
Collaborator

@kmcquade kmcquade commented Oct 6, 2020 •
edited
Loading

What does this PR do?

  • Removed extra unit tests - speeds up the unit tests from 3.5 minutes to less than 60 seconds

What gif best describes this PR or how it makes you feel?

image

Completion checklist

  • Additions and changes have unit tests
  • Python Unit tests, Pylint, security testing, and Integration tests are passing.
  • Javascript tests are passing (npm test)
  • If the UI contents or JavaScript files have been modified, generate a new example report (npm build and python3 ./utils/generate_example_report.py)
  • The pull request has been appropriately labeled using the provided PR labels

@kmcquade kmcquade self-assigned this Oct 6, 2020
@kmcquade kmcquade merged commit 9b234b4 into salesforce:master Oct 6, 2020
@kmcquade kmcquade deleted the fix/GH-117-remove-extra-unit-test branch October 6, 2020 15:11
@kmcquade kmcquade mentioned this pull request Oct 6, 2020
Closed
verkaufer pushed a commit to verkaufer/cloudsplaining that referenced this pull request Dec 10, 2020
@kmcquade @verkaufer
Removed extra unit tests - speeds up the unit tests from 3.5 minutes …
6a071fa 
…to less than 60 seconds (salesforce#118)
leonamagaya pushed a commit to leonamagaya/cloudsplaining that referenced this pull request Aug 19, 2025
@kmcquade
Removed extra unit tests - speeds up the unit tests from 3.5 minutes …
bf1a356 
…to less than 60 seconds (salesforce#118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kmcquade kmcquade

Labels

backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kmcquade