Skip to content

Conversation

@gruebel
Copy link
Collaborator

@gruebel gruebel commented Aug 7, 2023

What does this PR do?

  • Handles federated principals correctly, because currently they are ignored when used in an assume role policy

What gif best describes this PR or how it makes you feel?

Completion checklist

  • Additions and changes have unit tests
  • The pull request has been appropriately labeled using the provided PR labels
  • GitHub actions automation is passing (make test, make lint, make security-test, make test-js)
  • If the UI contents or JavaScript files have been modified, generate a new example report:
# Generate the updated Javascript bundle
make build-js

# Generate the example report
make generate-report

@kmcquade kmcquade merged commit 2483fe3 into salesforce:master Aug 12, 2023
@gruebel gruebel deleted the add-federated-principal branch August 13, 2023 19:41
leonamagaya pushed a commit to leonamagaya/cloudsplaining that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants