Skip to content

replace usage of findDOMNode with creating selfRef in constructor #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2022
Merged

replace usage of findDOMNode with creating selfRef in constructor #3054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2748c42
replace usage of findDOMNode with creating selfRef in constructor
DNiederweis Jun 27, 2022
845b07b
deleted findDOMNode that was commented out for testing
DNiederweis Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions components/modal/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ class Modal extends React.Component {
if (props.ariaHideApp) {
checkAppElementIsSet();
}

this.selfRef = React.createRef();
}

componentDidMount() {
Expand All @@ -224,14 +226,13 @@ class Modal extends React.Component {
// and manager.jsx are removed. They appear to have
// been created in order to do modals in portals.
if (!this.isUnmounting) {
const el = ReactDOM.findDOMNode(this); // eslint-disable-line react/no-find-dom-node
if (
el &&
el.parentNode &&
el.parentNode.getAttribute('data-slds-modal')
this.selfRef &&
this.selfRef.parentNode &&
this.selfRef.parentNode.getAttribute('data-slds-modal')
) {
ReactDOM.unmountComponentAtNode(el);
document.body.removeChild(el);
ReactDOM.unmountComponentAtNode(this.selfRef);
document.body.removeChild(this.selfRef);
}
}
}
Expand Down