Fixed the lookup not updating when props.items changes #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Probably don't need the check, but better safe than sorry since the propTypes don't require the field. (That's actually something I feel should be changed everywhere in the repo. Add .isRequired to the end of propType declarations if it's a required prop.)
ivanbogdanov
pushed a commit
that referenced
this pull request
Oct 27, 2015
…with_new_props Fixed the lookup not updating when props.items changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@madpotato This will fix state.items not updating when passed new items via props. The reason it was working in the demo is pass by reference. Fix should be self-explanatory.