Skip to content

Fixed focus in SLDSLookup #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2015
Merged

Fixed focus in SLDSLookup #49

merged 3 commits into from
Nov 4, 2015

Conversation

@minevskiy
Copy link
Contributor

@minevskiy minevskiy commented Nov 3, 2015

@madpotato , this is the cause of menu not closing on selection:

  1. isOpen wasn't set to false because the blur event was not fired
  2. blur was not fired because there was no focus set in the first place
  3. focus was not set because of a bug in componentDidUpdate which is fixed in this PR

minevskiy
minevskiy reviewed Nov 3, 2015
View reviewed changes
components/SLDSLookup/index.jsx
Copy link
Contributor Author

@minevskiy minevskiy Nov 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there was a typo: selectIndex rather than selectedIndex

ivanbogdanov pushed a commit that referenced this pull request Nov 4, 2015
@ivansfdc
Merge pull request #49 from salesforce-ux/im-fix-lookup-focus
12a8305 
Fixed focus in SLDSLookup
@ivanbogdanov ivanbogdanov merged commit 12a8305 into master Nov 4, 2015
@minevskiy minevskiy deleted the im-fix-lookup-focus branch November 4, 2015 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@minevskiy @ivanbogdanov