Skip to content

Remove styling rules #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Remove styling rules #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2833726
Remove style config from package
pmdartus Dec 5, 2018
f0204f1
Update README.md
pmdartus Dec 5, 2018
42c5931
Remove style.js from the list of published files
pmdartus Dec 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ Example of `.eslintrc`:

```json
{
"extends": ["@salesforce/eslint-config-lwc/recommended", "@salesforce/eslint-config-lwc/style"]
"extends": ["@salesforce/eslint-config-lwc/recommended"]
}
```

For more details about configuration please refer to the dedicated section in the ESLint documentation: https://eslint.org/docs/user-guide/configuring#using-a-shareable-configuration-package

## Configurations

This package exposes 4 configurations for your usage.
This package exposes 3 configurations for your usage.

### `@salesforce/eslint-config-lwc/base` configuration

Expand All @@ -45,15 +45,7 @@ Prevent common Javascript pitfalls and enforces all best practices.
### `@salesforce/eslint-config-lwc/extended` configuration

**Goal:**
Restrict usage of some Javascript language features known to be slow after the _COMPAT_ transformation. LWC runs in _COMPAT_ mode on older browsers (eg. IE11). To support new Javascript syntax and language features on older browser the LWC compiler transforms LWC modules. This linting configuraton targets patterns known to be slow in _COMPAT_ mode..
Restrict usage of some Javascript language features known to be slow after the _COMPAT_ transformation. LWC runs in _COMPAT_ mode on older browsers (eg. IE11). To support new Javascript syntax and language features on older browser the LWC compiler transforms LWC modules. This linting configuration targets patterns known to be slow in _COMPAT_ mode.

**Rules:**
`@salesforce/eslint-config-lwc/recommended` rules + restrict usage of some slow patterns in _COMPAT_.

### `@salesforce/eslint-config-lwc/style` configuration

**Goal:**
Enforces Salesforce code style rules for LWC modules.

**Rules:**
Some of the [Stylistic Issues](https://eslint.org/docs/rules/#stylistic-issues) and [_Best Practices_](https://eslint.org/docs/rules/#best-practices) rules.
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
"base.js",
"extended.js",
"index.js",
"recommended.js",
"style.js"
"recommended.js"
],
"husky": {
"hooks": {
Expand Down
82 changes: 0 additions & 82 deletions style.js
View file
Open in desktop

This file was deleted.

75 changes: 0 additions & 75 deletions test/style.js
View file
Open in desktop

This file was deleted.