chore: upgrade @lwc/eslint-plugin-lwc and add rules to recommended preset #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the recommended preset to disallow mixed use of upper case and underscore in api fields/methods.
jodarove
force-pushed
the
jodarove/prevent-api-with-mixed-uppercase-and-underscore
branch
from
c7d3b22 to
11984b4
Compare
pmdartus
approved these changes
Jan 7, 2021
pmdartus
reviewed
Jan 7, 2021
| '@lwc/lwc/no-document-query': 'error', | ||
| '@lwc/lwc/no-inner-html': 'error', | ||
| '@lwc/lwc/no-leading-uppercase-api-name': 'error', | ||
| '@lwc/lwc/valid-api': [ |
Contributor
There was a problem hiding this comment.
What do you think about also enabling: https://github.com/salesforce/eslint-plugin-lwc/blob/v0.11.0/docs/rules/prefer-custom-event.md ?
pmdartus
approved these changes
Jan 8, 2021
Contributor
|
Last inquiry for you @jodarove, what do you think about also adding I am surprised that we missed it. Because we already had 2 issues (salesforce/eslint-plugin-lwc#56 and salesforce/eslint-plugin-lwc#25), I think it's something that would be really useful to land sooner than later. =) |
jodarove
changed the title
jodarove
deleted the
jodarove/prevent-api-with-mixed-uppercase-and-underscore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In this PR:
lwc/valid-apiin the recommended preset, disallowing mixed use of upper case and underscore in API fields and methods.lwc/prefer-custom-eventto the recommended preset.lwc/no-dupe-class-membersto the recommended preset.