Skip to content

Verify protos with strange casing generate correctly #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2019
Merged

Verify protos with strange casing generate correctly #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jprotoc/jprotoc-test/src/test/java/com/salesforce/jprotoc/ProtoTypeMapTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ public void invalidClassNames() {
assertProtoTypeMapping(".com.salesforce.invalid.enye.TimeResponse", com.salesforce.invalid.enye.WeylandYutani.TimeResponse.class);
}

@Test
public void wonkyCasedNames() {
assertProtoTypeMapping(".HELLOworld.HelloUPPERRequest", HELLOworld.HelloUPPERRequest.class);
}

private void assertProtoTypeMapping(String protoTypeName, Class clazz) {
assertThat(protoTypeMap.toJavaTypeName(protoTypeName)).isEqualTo(fileNameToLexicalName(clazz.getName()));
}
Expand Down
16 changes: 16 additions & 0 deletions jprotoc/jprotoc-test/src/test/proto/funWITHcasEs.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
syntax = "proto3";

option java_multiple_files = true;

package HELLOworld;

// The greeting service definition.
service Greeter {
// Sends a greeting
rpc SayHello (HelloUPPERRequest) returns (HelloUPPERRequest) {}
}

// The request message containing the user's name.
message HelloUPPERRequest {
string name = 1;
}