Skip to content

fix: regex for new inquirer select #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix: regex for new inquirer select #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7772a6
fix: regex for interactive lists
mshanemc Jan 12, 2024
9ec1237
docs: linkinator
mshanemc Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
## Contributing

1. The [DEVELOPING](DEVELOPING.md) doc has details on how to set up your environment.
1. Familiarize yourself with the codebase by reading the [docs](docs), which you can generate locally by running `yarn docs`.
1. Create a new issue before starting your project so that we can keep track of
what you are trying to add/fix. That way, we can also offer suggestions or
let you know if there is already an effort in progress.
Expand Down
4 changes: 0 additions & 4 deletions DEVELOPING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ This cleans all generated files and directories. Run `yarn clean-all` to also cl

This tests the typescript using ts-node.

### `yarn docs`

This generates documentation into [docs](docs).

### `yarn lint`

This lints all the typescript. If there are no errors/warnings
Expand Down
2 changes: 1 addition & 1 deletion LICENSE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2023, Salesforce.com, Inc.
Copyright (c) 2024, Salesforce.com, Inc.
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[![NPM](https://img.shields.io/npm/v/@salesforce/cli-plugins-testkit.svg)](https://www.npmjs.com/package/@salesforce/cli-plugins-testkit)
[![CircleCI](https://circleci.com/gh/salesforcecli/cli-plugins-testkit.svg?style=svg&circle-token=2377ca31221869e9d13448313620486da80e595f)](https://circleci.com/gh/salesforcecli/cli-plugins-testkit)

# Description

Expand Down
5 changes: 4 additions & 1 deletion src/execCmd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,10 @@ export async function execInteractiveCmd(
const shouldScrollForAnswer = current.includes('❯') && scrollTarget;

if (shouldScrollForAnswer) {
const regex = /(?<=❯\s)(.*)/g;
// recent inquirer versions include a unicode character in the prompt that we need to strip out
// it's something like a backspace or a backline character used to type over existing output
// this generally removes all the "control" characters in the first section of unicode
const regex = /(?<=❯\s)([\u0020-\u00d7ff]+)/g;
const selected = (current.match(regex) ?? [''])[0].trim();
if (selected === scrollTarget) {
seen.add(matchingQuestion);
Expand Down