Skip to content

Conversation

@cristiand391
Copy link
Member

@cristiand391 cristiand391 commented Sep 5, 2025

What does this PR do?

Updates publish-mcp workflow to generate a shrinkwrap lockfile for @salesforce/mcp.

npm shrinkwrap doesn't support monorepos/workspaces:

➜  mcp git:(cd/lockfile) pwd
/Users/cdominguez/code/gh/mcp-shrink/mcp/packages/mcp
➜  mcp git:(cd/lockfile) npm shrinkwrap
npm error code ENOWORKSPACES
npm error This command does not support workspaces.
npm error A complete log of this run can be found in: /Users/cdominguez/.npm/_logs/2025-10-24T20_47_00_712Z-debug-0.log

so when publishing we copy packages/mcp to a single dir and run npm shrinkwrap to generate a lockfile before running npm publishing.

Testing

See lockfile included here:
https://www.npmjs.com/package/@salesforce/mcp/v/0.23.5-dev.1?activeTab=code

install @salesforce/mcp@0.23.5-dev.1 and verify tools can be called.

What issues does this PR fix or reference?

@W-19291869@

@cristiand391 cristiand391 marked this pull request as ready for review October 24, 2025 20:49
@cristiand391 cristiand391 requested a review from a team as a code owner October 24, 2025 20:49
Copy link
Collaborator

@iowillhoit iowillhoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Confirmed the shrinkwrap is generated and able to start the server

@iowillhoit iowillhoit merged commit 915e19d into main Nov 7, 2025
26 of 27 checks passed
SamarthAroraa pushed a commit to SamarthAroraa/mcp that referenced this pull request Nov 17, 2025
* fix: add shrinkwrap lockfile

* chore(release): 0.19.2-dev.0 [skip ci]

* chore: use gha runner tempdir

* chore(release): 0.19.2-dev.1 [skip ci]

* chore: remove git markers, add comment

[skip ci]

* chore(release): 0.23.5-dev.0 [skip ci]

* chore: fix workflow

[skip ci]

* chore(release): 0.23.5-dev.1 [skip ci]

* chore: typo

[skip ci]

---------

Co-authored-by: svc-cli-bot <Svc_cli_bot@salesforce.com>
Co-authored-by: Willhoit <iowillhoit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants