For app:create and autoinstall:app:create, allow setting the app's name, label, and description via flags#249
Merged
aarondailsf2023 merged 1 commit intomainfrom Mar 24, 2023
Conversation
Collaborator
|
Looks good. Is the app description honored when sending a description in a definition file with a description? Guessing not because of the same bug on the server side |
smithgp
approved these changes
Mar 23, 2023
Contributor
Author
@reidaelliott -- the autoinstall app create command (unless I am missing it) doesn't take a definition file flag so I am speculating but I think I think your right, it wouldn't work due to that bug. |
feat: update autoinstall:app:create to take --appname and --appdescription flags
aarondailsf2023
force-pushed
the
adail/new-appname-and-appdescription-args
branch
from
acd1097 to
dcce9f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For both commands, --appname sets both the created app's name and label (this is the existing behavior of --appname for app:create), and --appdescription sets its description.
Though one note for the autoinstall:app:create command specifically, due to W-12729893 --appdescription currently won't be honored on the backend. Sending it doesn't cause an error, but the autoinstalled app will still be created w/ the default description (which is blank). Once that defect is fixed this should start to work.
What issues does this PR fix or reference?
@W-12722796@