fix(web): refactor logic/fix scopes W-20329175 #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iowillhoit
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
follow up of #1420
#1420 was wrong, I got it wrong due to the method signature allowing multiple
string | undefinedargs (bad pattern!).This PR refactors
executeLoginFlow to take an object with the right properties, so noworg login web` should support both the "normal" auth and the "link app" mode.Also added a parse func to
--scopesto throw better errors if a user separates scopes with commas instead of spaces.What issues does this PR fix or reference?
@W-20329175@