fix(flags): deprecate async/wait flags without bulk#1002
Merged
Conversation
dependsOn boolean flagsasync/wait flags without bulk
Contributor
|
QA: |
mshanemc
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecates using
--waitand--asyncondata querywithout--bulk.Can't remove because there a few thousands executions still running
sf data query --wait, this will go through our deprecation policy.ignore this, we can't remove it now without breaking users.
Updates
--waitand--asyncflags indata queryto use oclif's relationship feature instead ofdependsOna boolean flag.Found by the new eslint rule:
https://github.com/salesforcecli/eslint-plugin-sf-plugin/actions/runs/10097996137/job/27924166840?pr=447
This introduces a behavior change because both flags were depending on
bulkwhich has default value (false), so the following scenarios were allowed accidentally:due to how
data queryconditionally queried the records, these commands also didn't fail/affect output:plugin-data/src/commands/data/query.ts
Lines 112 to 124 in 5386b61
with this PR both examples will fail
TODO:
check telemetry, don't want to break a ton of users.
What issues does this PR fix or reference?
@W-16320656@