Skip to content

fix: dedup jsforce#385

Merged
cristiand391 merged 1 commit intomainfrom
cd/dedup-jsforce
Oct 25, 2022
Merged

fix: dedup jsforce#385
cristiand391 merged 1 commit intomainfrom
cd/dedup-jsforce

Conversation

@cristiand391
Copy link
Copy Markdown
Member

What does this PR do?

updates jsforce version field in the pjson to use carets and the whole beta tag and version instead of just beta.
Even deduping deps with yarn-deduplicate, when creating an sfdx RC it would still get multiple versions of jsforce due to the beta tag and some outdated deps also pinning to beta.

yarn-deduplicate supports dedup of pre-releases but it needs the major.minor.patch format to be able to work:
https://github.com/scinos/yarn-deduplicate#pre-release-versions

What issues does this PR fix or reference?

[skip-validate-pr]

'soql.txt',
])
.it('should throw an error when both query (inline/file query) flags are specified', (ctx) => {
expect(ctx.stderr).to.include('--soqlqueryfile= cannot also be provided when using --query=');
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oclif/core change I think (bumped salesforce/command)

@iowillhoit iowillhoit self-requested a review October 25, 2022 14:23
"@salesforce/command": "^5.2.4",
"@salesforce/core": "^3.30.3",
"@salesforce/command": "^5.2.16",
"@salesforce/core": "^3.31.17",
Copy link
Copy Markdown
Member Author

@cristiand391 cristiand391 Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old core was also specifying jsforce: "beta" so plugin-data was getting another jsforce version. Latest core
allows to dedup. ditto command.

https://github.com/forcedotcom/sfdx-core/blame/4b6f99b44b77989fc525460391b41da62deb62a8/package.json#L51

@cristiand391 cristiand391 merged commit 4fec7cc into main Oct 25, 2022
@cristiand391 cristiand391 deleted the cd/dedup-jsforce branch October 25, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants