Skip to content

Conversation

@mdonnalley
Copy link
Collaborator

What does this PR do?

Migrate to ESM

What issues does this PR fix or reference?

@W-14487112@

@mshanemc mshanemc requested a review from a team as a code owner November 20, 2023 20:37
@mshanemc
Copy link
Contributor

qa: generated a plugin for internal and external.

✅ looked ok
✅ internal had the salesforce copyright header stuff, external didn't
✅ internal had the top-level license.txt file, external didn't

unit: boolean;
}

const TEMPLATES_DIR = path.join(path.dirname(fileURLToPath(import.meta.url)), '../../templates');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's good

import { readJson } from '../util';

// eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-unsafe-assignment
const { version } = require('../../package.json');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also a good choice

@mshanemc mshanemc merged commit c2f1783 into main Nov 21, 2023
@mshanemc mshanemc deleted the mdonnalley/esm branch November 21, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants