-
Notifications
You must be signed in to change notification settings - Fork 2
feat!: migrate to ESM #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGES: ESM and node 18 minimum
|
qa: generated a plugin for internal and external. ✅ looked ok |
| unit: boolean; | ||
| } | ||
|
|
||
| const TEMPLATES_DIR = path.join(path.dirname(fileURLToPath(import.meta.url)), '../../templates'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's good
| import { readJson } from '../util'; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-unsafe-assignment | ||
| const { version } = require('../../package.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also a good choice
What does this PR do?
Migrate to ESM
What issues does this PR fix or reference?
@W-14487112@