Skip to content

Conversation

@mdonnalley
Copy link
Collaborator

What does this PR do?

Runs yarn-deduplicate on newly generated plugin before installing the dependencies. This avoids potential issues with @salesforce/sf-plugins-core brining in a unique version of @salesforce/core that causes typescript to complain about non-portable types.

What issues does this PR fix or reference?

@W-16001680@

@mshanemc
Copy link
Contributor

QA notes: ran with this plugin yarn-linked onto the CLI, adding flags to various commands in plugin-org
✅ Works fine (but I couldn't reproduce Juliet's original error, either)

gonna merge and then run one just to force the JIT install process to happen

@mshanemc mshanemc merged commit 381cee4 into main Jun 14, 2024
@mshanemc mshanemc deleted the mdonnalley/yarn-dedupe branch June 14, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants