W-16025394 feat: no more yeoman #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshackell-sfdc
approved these changes
Jul 26, 2024
| } | ||
|
|
||
| this.ux.log(`${updating} package.json`); | ||
| await writeFile(join(this.cwd, 'package.json'), JSON.stringify(this.pjson, null, 2)); |
Contributor
There was a problem hiding this comment.
we had to normalize this path to fix a bug recently might need to be carried over here too
WillieRuemmele
approved these changes
Jul 29, 2024
Contributor
QA Notes✅ : no ➜ plugin-dev git:(mdonnalley/no-yeoman)
➜ yarn why yeoman
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "yeoman"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
error We couldn't find a match!
✨ Done in 0.24s.
➜ testing/bin/run.js hello:world
Hello World at Mon Jul 29 2024.✅ : internal plugin correct
✅ : plugin checks performed and passed
✅ : previous checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dev generate command|library|plugin)--dry-runflag todev generate command|library|pluginWhat issues does this PR fix or reference?
@W-16025394@