fix: add package prefix to CDC channel name #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanRomero84
commented
Aug 31, 2023
| */ | ||
| protected catch(error: Error | SfError): Promise<SfCommand.Error> { | ||
| if (error.name.includes('GenericTimeoutError')) { | ||
| if (error.name && error.name.includes('GenericTimeoutError')) { |
Collaborator
Author
There was a problem hiding this comment.
I added this check because it was failing due to null pointe.
npiccolo
approved these changes
Aug 31, 2023
Contributor
npiccolo
left a comment
npiccolo
left a comment
There was a problem hiding this comment.
Looks good !!
Thanks Esteban !
EstebanRomero84
added a commit
that referenced
this pull request
Aug 31, 2023
* fix: add package prefix to CDC channel name (#229) * chore(release): 1.1.1-beta.0 --------- Co-authored-by: svc-cli-bot <svc_cli_bot@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the DCD channel name to include the namespace prefix
sf_devops__.What issues does this PR fix or reference?
W-14050465
Functionality Before
The plugin attempts to subscribe to DCD channel to monitor the progress operation. In production orgs it fails because the channel name is missing the prefix.
Functionality After
The plugin successfully subscribes to DCD channel.