fix: update functions templates with functions-core 0.2.8 #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git2Gus App is installed but the |
joshwlewis
changed the title
joshwlewis
changed the title
mimen
approved these changes
Apr 13, 2022
colincasey
added a commit
that referenced
this pull request
Apr 18, 2022
* main: fix: update functions templates with functions-core 0.2.8 (#403) # Conflicts: # package.json # test/commands/run/function/start.test.ts # yarn.lock
Member
|
@joshwlewis Hi! Why was the The commit message gives no reason other than: The shortened path is harder to grep when doing eg GitHub code search, and is inconsistent with all other packages in this project and how people typically use |
Collaborator
Author
|
The commit previous to that failed CI: https://circleci.com/gh/salesforcecli/plugin-functions/8514?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link. There's a check that ensures no file paths are beyond a certain length to prevent compatibility issues on Windows. ¯_(ツ)_/¯ |
Collaborator
Author
|
@edmorley - Here's a related PR in which I shortened the paths in sf-functions-core for the same reason: https://github.com/heroku/sf-functions-core/pull/22 |
edmorley
added a commit
that referenced
this pull request
Jan 31, 2023
In #403 and heroku/sf-functions-core#22 various measures were taken to try and shorten the maximum on-disk filepath of files in the two packages, so as to prevent the CI failures seen in: https://app.circleci.com/pipelines/github/salesforcecli/plugin-functions/2415/workflows/510a1bac-1a64-4a1b-a5a5-e765100b08d2/jobs/8514 One of these measure was to use a package alias of `@hk/functions-core` for the `@heroku/functions-core` package, so the on-disk directory path was 4 characters shorter. However, this change stops Dependabot from working, and looking at recent tarfile verification logs in CI, it appears we might not need to save these four characters any more - since none of the salesforce-core dep paths appear in the "close to the limit" warnings. As such, we can undo this aliasing, to fix Dependabot for this package.
edmorley
added a commit
that referenced
this pull request
Jan 31, 2023
…ency name In #403 and heroku/sf-functions-core#22 various measures were taken to try and shorten the maximum on-disk filepath of files in the two packages, so as to prevent the CI failures seen in: https://app.circleci.com/pipelines/github/salesforcecli/plugin-functions/2415/workflows/510a1bac-1a64-4a1b-a5a5-e765100b08d2/jobs/8514 One of these measure was to use a package alias of `@hk/functions-core` for the `@heroku/functions-core` package, so the on-disk directory path was 4 characters shorter. However, this change stops Dependabot from working, and looking at recent tarfile verification logs in CI, it appears we might not need to save these four characters any more - since none of the salesforce-core dep paths appear in the "close to the limit" warnings. As such, we can undo this aliasing, to fix Dependabot for this package.
edmorley
added a commit
that referenced
this pull request
Jan 31, 2023
…ency name In #403 and heroku/sf-functions-core#22 various measures were taken to try and shorten the maximum on-disk filepath of files in the two packages, so as to prevent the CI failures seen in: https://app.circleci.com/pipelines/github/salesforcecli/plugin-functions/2415/workflows/510a1bac-1a64-4a1b-a5a5-e765100b08d2/jobs/8514 One of these measure was to use a package alias of `@hk/functions-core` for the `@heroku/functions-core` package, so the on-disk directory path was 4 characters shorter. However, this change stops Dependabot from working, and looking at recent tarfile verification logs in CI, it appears we might not need to save these four characters any more - since none of the salesforce-core dep paths appear in the "close to the limit" warnings. As such, we can undo this aliasing, to fix Dependabot for this package. @W-12466399@
edmorley
added a commit
that referenced
this pull request
Feb 1, 2023
…ency name (#595) In #403 and heroku/sf-functions-core#22 various measures were taken to try and shorten the maximum on-disk filepath of files in the two packages, so as to prevent the CI failures seen in: https://app.circleci.com/pipelines/github/salesforcecli/plugin-functions/2415/workflows/510a1bac-1a64-4a1b-a5a5-e765100b08d2/jobs/8514 One of these measure was to use a package alias of `@hk/functions-core` for the `@heroku/functions-core` package, so the on-disk directory path was 4 characters shorter. However, this change stops Dependabot from working, and looking at recent tarfile verification logs in CI, it appears we might not need to save these four characters any more - since none of the salesforce-core dep paths appear in the "close to the limit" warnings. As such, we can undo this aliasing, to fix Dependabot for this package. @W-12466399@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
@salesforce/functions-coreto 0.2.8. Which includes some function template updates: https://github.com/heroku/sf-functions-core/pull/46 and https://github.com/heroku/sf-functions-core/pull/43.What issues does this PR fix or reference?
@W-10728914@