fix(deps): Switch back to non-shortened @heroku/functions-core dependency name #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git2Gus App is installed but the |
Member
Author
|
The filepath length check is still passing after this change (the warnings below are unrelated and pre-existing): (https://github.com/salesforcecli/plugin-functions/actions/runs/4056605456/jobs/6981297126) |
…ency name In #403 and heroku/sf-functions-core#22 various measures were taken to try and shorten the maximum on-disk filepath of files in the two packages, so as to prevent the CI failures seen in: https://app.circleci.com/pipelines/github/salesforcecli/plugin-functions/2415/workflows/510a1bac-1a64-4a1b-a5a5-e765100b08d2/jobs/8514 One of these measure was to use a package alias of `@hk/functions-core` for the `@heroku/functions-core` package, so the on-disk directory path was 4 characters shorter. However, this change stops Dependabot from working, and looking at recent tarfile verification logs in CI, it appears we might not need to save these four characters any more - since none of the salesforce-core dep paths appear in the "close to the limit" warnings. As such, we can undo this aliasing, to fix Dependabot for this package. @W-12466399@
edmorley
force-pushed
the
edmorley/functions-core-dep-specifier
branch
from
8133290 to
5cb9073
Compare
Malax
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #403 and heroku/sf-functions-core#22 various measures were taken to try and shorten the maximum on-disk filepath of files in the two packages, so as to prevent the CI failures seen in:
https://app.circleci.com/pipelines/github/salesforcecli/plugin-functions/2415/workflows/510a1bac-1a64-4a1b-a5a5-e765100b08d2/jobs/8514
One of these measure was to use a package alias of
@hk/functions-corefor the@heroku/functions-corepackage, so the on-disk directory path was 4 characters shorter.However, this change stops Dependabot from working, and looking at recent tarfile verification logs in CI, it appears we might not need to save these four characters any more - since none of the salesforce-core dep paths appear in the "close to the limit" warnings.
As such, we can undo this aliasing, to fix Dependabot for this package.
@W-12466399@